[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

Dmitry Borisenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 13 09:15:43 PST 2017


dmitry added a comment.

@yaxunl, we already have the similar issue for atomics. Probably we can extend typedef semantic checks but I don't think it's a good idea since C and C++ have the similar problem but they don't provide special treatment for types from their standard libraries. I think the proposed approach conforms to general practice and I also think that it's better than to check canonical type and therefore to restrict ndrange_t with a particular non-standard implementation or do you envision something different from the canonical type checking in mind?


https://reviews.llvm.org/D28058





More information about the cfe-commits mailing list