[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

Dehao Chen via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 12 16:35:15 PST 2017


On Thu, Jan 12, 2017 at 3:27 PM, Teresa Johnson via Phabricator <
reviews at reviews.llvm.org> wrote:

> tejohnson added a comment.
>
> In https://reviews.llvm.org/D28588#644489, @danielcdh wrote:
>
> > Thanks for the prompt response.
> >
> > But looks like several other tests also has "-mllvm
> -debug-pass=Structure" in their tests:
> >
> > tools/clang/test/CodeGen/pgo-instrumentation.c
> >  test/CodeGen/Generic/llc-start-stop.ll
> >
> > I just verified that if I cmake with -DCMAKE_BUILD_TYPE=Release, it
> still passes locally.
>
>
> Hmm, maybe that flavor of -debug output is enabled with NDEBUG then. I'm
> not really sure unfortunately.
>
> I don't even see an error message for the second one, do you? Just an
> error code.
>

>From the first buildbot failure (windows), looks like it's not just lack of
output, but also the compile command failed:

note: command had no output on stdout or stderr
error: command failed with exit status: 1

But it did not provide why it exits non-zero.

Dehao


>
> > Thanks,
> > Dehao
>
>
>
>
> https://reviews.llvm.org/D28588
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170112/2dfc23a0/attachment.html>


More information about the cfe-commits mailing list