[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

Tim Shen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 9 14:25:47 PST 2017

timshen added a comment.

In https://reviews.llvm.org/D27872#639020, @hfinkel wrote:

> it is not at all obvious what is going on (i.e. why are we casting to integers?). Maybe semPPCDoubleDoubleImpl needs a better name now? It seems confusing to have semPPCDoubleDoubleImpl and semPPCDoubleDouble where one is not really an "implementation" class of the other.

This is true. I renamed it to semPPCDoubleDoubleLegacy, and modified its documentation. I didn't put the documentation for each of the uses, because that'd be too verbose.


More information about the cfe-commits mailing list