[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 9 07:33:02 PST 2017

nemanjai added inline comments.

Comment at: test/CodeGen/builtins-ppc-extractword-error.c:2
+// REQUIRES: powerpc-registered-target
+// XFAIL: powerpc
I think this will fail on all the powerpc targets, such as powerpc64le, etc. Which isn't what you want I imagine.
Also, I think this isn't really the idea with XFAIL. The semantics we'd probably want are better served by using the `not` tool and checking for the error messages. You should be able to find some example of how the `not` tool is used in some of the other test cases (for example `test/CodeGen/builtins-ppc-p7-disabled.c`).



More information about the cfe-commits mailing list