[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

Beren Minor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 9 06:50:50 PST 2017


berenm added a comment.

I'm trying to think of a scenario where *, && or & before tokens to be aligned would not indicate pointers or references, but as the alignment is only done for now on declarations and assignments, I can't find one.

Maybe you could add one more test case to check Left pointer alignment, as all the tests are apparently aligned Right by default ?

This looks good to me, although it will conflict with https://reviews.llvm.org/D21279, so one or the other has to be merged first and the other rebased.


https://reviews.llvm.org/D27651





More information about the cfe-commits mailing list