[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

[Malcolm Parsons via Phabricator via cfe-commits]

malcolm.parsons added inline comments.


================
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:100
+  StringRef ReplacementStr =
+      IsNoThrow ? NoexceptMacro.empty() ? "noexcept" : NoexceptMacro
+                : DtorOrOperatorDel ? "noexcept(false)" : "";
----------------
alexfh wrote:
> Did you consider auto-detection approach like in `getFallthroughAttrSpelling` in tools/clang/lib/Sema/AnalysisBasedWarnings.cpp?
cpp11-migrate used to do this for -add-override - rL183001.
clang-tidy's modernize-use-override check doesn't even have an option.


https://reviews.llvm.org/D20693