[PATCH] D28220: provide Win32 native threading

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added a comment.

I'm seeing the following build errors on Windows:

  C:\Users\Eric\workspace\libcxx\include\__threading_support(521,3):  warning: cannot delete expression with pointer-to-'void' type 'void *' [-Wdelete-incomplete]
    delete __data;
    ^      ~~~~~~
  C:\Users\Eric\workspace\libcxx\include\__threading_support(530,18):  error: assigning to 'void *(*)(void *)' from incompatible type 'void (*)(void *)': different return type ('void *' vs 'void')
    data->__func = __func;
                   ^~~~~~
  C:\Users\Eric\workspace\libcxx\include\__threading_support(572,5):  error: functions that differ only in their return type cannot be overloaded
  int __libcpp_thread_yield()
  ~~~ ^
  C:\Users\Eric\workspace\libcxx\include\__threading_support(178,6):  note: previous declaration is here
  void __libcpp_thread_yield();
  ~~~~ ^
  C:\Users\Eric\workspace\libcxx\include\__threading_support(589,5):  error: functions that differ only in their return type cannot be overloaded
  int __libcpp_tls_get(__libcpp_tls_key __key)
  ~~~ ^
  C:\Users\Eric\workspace\libcxx\include\__threading_support(185,7):  note: previous declaration is here
  void *__libcpp_tls_get(__libcpp_tls_key __key);
  ~~~~~~^
  C:\Users\Eric\workspace\libcxx\include\__threading_support(591,10):  error: cannot initialize return object of type 'int' with an rvalue of type 'PVOID' (aka 'void *')
    return FlsGetValue(__key);


https://reviews.llvm.org/D28220