[PATCH] D28320: [Driver] Driver changes to support CUDA compilation on Windows.

[Justin Lebar via Phabricator via cfe-commits]

jlebar marked an inline comment as done.
jlebar added a comment.

Thank you for the reviews!



================
Comment at: clang/lib/Driver/ToolChains.cpp:1819
         Args.getLastArgValue(options::OPT_cuda_path_EQ));
-  else {
+  else if (HostTriple.isOSLinux() || HostTriple.isMacOSX()) {
     CudaPathCandidates.push_back(D.SysRoot + "/usr/local/cuda");
----------------
tra wrote:
> I'd keep unix-like paths as defaults under else {}.
> If you do want to enumerate supported OS variants explicitly, then me want to throw an error if particular host OS is not supported.
> 
Sure, done locally, will be reflected when I commit.


https://reviews.llvm.org/D28320