[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

[Adrian Prantl via Phabricator via cfe-commits]

aprantl added inline comments.


================
Comment at: include/clang/Basic/DiagnosticSerializationKinds.td:131
+  "diagnostic options now it is a non-system module">,
+  InGroup<ModuleConflict>;
+
----------------
Is this better?

"module file '%0' was validated as a system module and is now being imported as a non-system module; any differences in diagnostics options will be ignored"


================
Comment at: include/clang/Basic/DiagnosticSerializationKinds.td:135
+  "module file '%0' was validated in an ancestor thread, now it needs to "
+  "be invalidated">;
+
----------------
I wonder if there is a way to rephrase this message such that an end-user could understan how to interpret this error?


https://reviews.llvm.org/D28299