[PATCH] D28223: clean up use of _WIN32

Kim Gräsman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 12:03:22 PST 2017


kimgr added a comment.

Another belated thought: it all depends on the intended meaning of the symbol:

- Does it say anything about the element size (i.e. sizeof(wchar_t)?
- Does it specify the native encoding of wide-char strings for a platform (i.e. UTF-16 on Windows)?

It looks like the same symbol is now used for both things, which may not be a good idea.


Repository:
  rL LLVM

https://reviews.llvm.org/D28223





More information about the cfe-commits mailing list