[PATCH] D28166: Properly merge K&R functions that have attributes

Richard Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 11:34:06 PST 2017


rsmith added a comment.

In https://reviews.llvm.org/D28166#634196, @aaron.ballman wrote:

> So I think the correct behavior is to only enable the vararg behavior when the function is variadic with an ellipsis rather than variadic due to a lack of prototype.


That sounds right. Note that functions with no prototype are not actually variadic, so it's permitted for a vararg definition to use a different calling convention from a no-prototype call, as happens in this case.


https://reviews.llvm.org/D28166





More information about the cfe-commits mailing list