[PATCH] D28220: provide Win32 native threading

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added inline comments.


================
Comment at: include/__threading_support:44
+#define WIN32_LEAN_AND_MEAN
+#define VC_EXTRA_LEAN
+#include <Windows.h>
----------------
Do these definitions have any affect when `<Windows.h>` has already been included?
Also are these definitions required before including the header, or merely beneficial? If they are required this will make the `<Windows.h>` header a pain to use with modules.




================
Comment at: include/__threading_support:306
+_LIBCPP_ALWAYS_INLINE
+int __libcpp_recursive_mutex_init(__libcpp_mutex_t* __m)
+{
----------------
The initial `__libcpp_foo` declarations specify the correct linkage and visibility attributes. Please don't decorate the definitions.


Repository:
  rL LLVM

https://reviews.llvm.org/D28220