[PATCH] D21298: [Clang-tidy] delete null check

Gergely Angeli via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 31 04:20:33 PST 2016


SilverGeri marked 5 inline comments as done.
SilverGeri added inline comments.


================
Comment at: docs/clang-tidy/checks/readability-delete-null-pointer.rst:7
+Checks the 'if' statements where a pointer's existence is checked and then deletes the pointer.
+The check is unnecessary as deleting a nullpointer has no effect.
+
----------------
alexfh wrote:
> alexfh wrote:
> > Either `null pointer` or `nullptr` (enclosed in double backquotes).
> Sorry for not being clear enough: "null pointer" is not an inline code snippet, it shouldn't be enclosed in double backquotes or anything else. The "(enclosed in double backquotes)" part was meant to apply to `nullptr` only (since it's a keyword and should be highlighted as a code snippet).
To be honest, I don't even understand why I did what I did... :D


https://reviews.llvm.org/D21298





More information about the cfe-commits mailing list