[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.
Arpith Jacob via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 30 16:47:33 PST 2016
arpith-jacob updated this revision to Diff 82750.
arpith-jacob added a comment.
Alexey, thank you for your review. I've updated the patch addressing your comments.
- I experimented with various ways of changing the name of the outlined function. In the end I decided against moving the two classes to the header file. Instead I pass the name to the class via the constructor. The name is returned by a virtual function.
- I also removed the overloaded implementation of getThreadID(). I'm fine using the default implementation. We do not use the value returned by getThreadID() in our runtime and prefer to recompute it using PTX reserved registers.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 30123 bytes
Desc: not available
More information about the cfe-commits