[PATCH] D27430: [libc++] Annotate template methods with visibility

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 29 21:38:10 PST 2016

EricWF added a comment.

Please put these attributes to the first declaration instead of the definition.

Comment at: include/thread:392
 template <class _Fp>
 thread::thread(_Fp __f)
We really should hide this using `inline _LIBCPP_INLINE_VISIBILITY` because it's a special C++03 symbol, so we don't even want a hidden definition omitted ideally.


More information about the cfe-commits mailing list