[PATCH] D27810: Normalize all filenames before searching FileManager caches

Yaron Keren via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 29 06:55:46 PST 2016

yaron.keren added inline comments.

Comment at: lib/Basic/FileManager.cpp:218
+#ifdef LLVM_ON_WIN32
+  SmallString<128> NormalizedPath(Filename.str());
+  llvm::sys::path::native(NormalizedPath);
I'd use a larger SmallString<256>, with large projects 128 bytes are frequently not enough.


More information about the cfe-commits mailing list