[PATCH] D27576: [libcxx] libc++ changes necessary for the externally threaded libcxxabi variant

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 23 19:57:12 PST 2016


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: test/CMakeLists.txt:58
 
 if (LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY)
+  set(LIBCXX_TEST_DEPS cxx_experimental)
----------------
I always prefer `set(LIBCXX_TEST_DEPS "")` to initialize an empty list. Then `list(APPEND LIBCXX_TEST_DEPS cxx_experimental)` to add new items.


https://reviews.llvm.org/D27576





More information about the cfe-commits mailing list