[PATCH] D28053: Cleanup the handling of noinline function attributes, -fno-inline, -fno-inline-functions, -O0, and optnone.

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added a comment.

> That said, I agree with Reid that it is a bit surprising. After thinking about it a lot, the reason I personally find it surprising is actually that I find -O0 being the default surprising. But I'm OK with not changing that here, and maybe never changing that at the CC1 layer.

We could reduce the "surprising effect" for LTO behavior by requiring an explicit -O when -flto is passed to the driver.

> Thoughts? Generally happy with this direction?

LGTM.


https://reviews.llvm.org/D28053