[clang-tools-extra] r290202 - [clang-tidy] Add modernize-use-default-member-init check

[NAKAMURA Takumi via cfe-commits]

Does the test invoke cl.exe? I supposed it were clang.

On Thu, Dec 22, 2016 at 11:24 PM Aaron Ballman <aaron at aaronballman.com>
wrote:

> On Wed, Dec 21, 2016 at 6:10 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> > It'd be the issue if the test depended on installed headers. The builder
> > doesn't have MS headers installed.
>
> Those type names do not require any headers to be installed. They're
> keywords in C++11 and later, but MSVC did not support them until MSVC
> 2015.
>
> ~Aaron
>
> >
> > On Thu, Dec 22, 2016 at 1:27 AM Aaron Ballman <aaron at aaronballman.com>
> > wrote:
> >>
> >> On Tue, Dec 20, 2016 at 5:58 PM, Malcolm Parsons
> >> <malcolm.parsons at gmail.com> wrote:
> >> > On 20 December 2016 at 22:32, Aaron Ballman <aaron at aaronballman.com>
> >> > wrote:
> >> >> On Tue, Dec 20, 2016 at 4:26 PM, Malcolm Parsons via cfe-commits
> >> >> <cfe-commits at lists.llvm.org> wrote:
> >> >>> Author: malcolm.parsons
> >> >>> Date: Tue Dec 20 15:26:07 2016
> >> >>> New Revision: 290202
> >> >>>
> >> >>> URL: http://llvm.org/viewvc/llvm-project?rev=290202&view=rev
> >> >>> Log:
> >> >>> [clang-tidy] Add modernize-use-default-member-init check
> >> >>>
> >> >>> Summary: Fixes PR18858
> >> >>
> >> >> This appears to have broken one of the bots:
> >> >>
> >> >> http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/33046
> >> >
> >> > error: unknown type name 'char16_t'
> >> > error: unknown type name 'char32_t'
> >> >
> >> > I see commented tests in other clang-tidy tests:
> >> >
> >> > // TODO: enable these tests once all supported compilers
> >> > // support char16_t and char32_t (VS2013 does not)
> >> >
> >> >     // disabled for now until it is clear
> >> >     // how to enable them in the test
> >> >     //} catch (const char16_t*) {
> >>
> >> We no longer support MSVC 2013, so that should not be an issue.
> >> Takumi, I'm not certain what to make of this builder (MSVC centos?).
> >> What version of Visual Studio is it compiling with? Or is this an
> >> instance where we need to set the -fms-compatibility-version=19 when
> >> running the test with clang-cl?
> >>
> >> ~Aaron
> >>
> >> >
> >> > --
> >> > Malcolm Parsons
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161222/d5af1df9/attachment.html>