[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 21 08:36:40 PST 2016


On Tue, Dec 20, 2016 at 5:58 PM, Kevin Puetz via Phabricator
<reviews at reviews.llvm.org> wrote:
> puetzk added a comment.
>
> I see that you added a FIXME mentioning that it should be C++-only, but I don't see where you actually did anything that would make it so. What am I missing?

You aren't missing anything, the fix isn't in yet -- the comment is
calling out that we should fix this at some point in the future.

> Also, did you mean to drop the changes to utils/TableGen/ClangAttrEmitter.cpp and bring back the WarnDiag, "ExpectedEnumOrClass" @aaron.ballman asked for in the first review?

That change appears to have been lost, and I would like to see them
brought back. I think they may have gotten lost during the rebase, as
they were present in https://reviews.llvm.org/D26846?id=78569.

~Aaron

>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D26846
>
>
>


More information about the cfe-commits mailing list