[PATCH] D28023: [analyzer] Fix leak false positives before no-return functions caused by incomplete analyses.

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 21 08:20:45 PST 2016


a.sidorin added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:3363
+    // we're post-dominated by.
+    // FIXME: This is far from enough to handle the incomplete analysis case.
+    // We may be post-dominated in subsequent blocks, or even
----------------
I took a brief look and found that we have Domination analysis for clang CFG but not PostDomination analysis. However, `llvm::DominatorTreeBase` that is used internally in `clang::DominatorTree` may be constructed for post-domination analysis. Is it possible to implement such analysis quickly (or modify `clang::DominatorTree` to support it)? If the answer is no, don't mind.


https://reviews.llvm.org/D28023





More information about the cfe-commits mailing list