[PATCH] D27710: [analyzer] Prohibit ExplodedGraph's edges duplicating

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 20 03:09:03 PST 2016


xazax.hun added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/CoreEngine.cpp:662
+  bool EdgeExists = false;
+  for (auto I = N->pred_begin(), E = N->pred_end(); I != E; ++I)
+    if (*I == FromN) {
----------------
I prefer having the braces written in this case, but it is a minor nit.

Wouldn't using an algorithm like std::find work as well?


Repository:
  rL LLVM

https://reviews.llvm.org/D27710





More information about the cfe-commits mailing list