[PATCH] D16171: Warning on redeclaring with a conflicting asm label

Leslie Zhai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 18 20:33:59 PST 2016

xiangzhai added a comment.

LLVMBUG-31017 https://llvm.org/bugs/show_bug.cgi?id=31017#c4

In https://reviews.llvm.org/D16171#540261, @phabricss wrote:

> On 09/12/2016 01:26 PM, Nick Lewycky wrote:
> > Firstly, I thought glibc had applied a patch to fix this bug? As in, the error is correct and glibc fixed their bug?
> I can confirm that the bug still exists in glibc 2.24 and HEAD from glibc git.  Also it appears that the issue on the llvm mailing list was just dropped without any resolution:
> r255371 - Error on redeclaring with a conflicting asm label <http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146075.html>
>   ../include/sys/stat.h:16:15: error: cannot apply asm label to function after its first use
>   hidden_proto (__fxstat)
>   ~~~~~~~~~~~~~~^~~~~~~~~
>   ./../include/libc-symbols.h:420:19: note: expanded from macro 'hidden_proto'
>     __hidden_proto (name, , __GI_##name, ##attrs)
>     ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   ./../include/libc-symbols.h:424:33: note: expanded from macro '__hidden_proto'
>     extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
> As far as your review of the patch by weimingz, that is beyond my skill level so I will let him reply.  Thanks!


More information about the cfe-commits mailing list