[PATCH] D27806: [clang-tidy] Add obvious-invalid-range

[Stanisław Barzowski via Phabricator via cfe-commits]

sbarzowski requested changes to this revision.
sbarzowski added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36
+    "std::for_each; std::find; std::find_if; std::find_end; "
+    "std::find_first_of; std::adjacent_find; std::count; std::count_if;"
+    "std::mismatch; std::equal; std::search; std::copy; "
+    "std::copy_backward; std::swap_ranges; std::transform; std::replace"
+    "std::replace_if; std::replace_copy; std::replace_copy_if; std::fill; "
+    "std::fill_n; std::generate; std::generate_n; std::remove; std::remove_if"
+    "std::remove_copy; std::remove_copy_if; std::unique; std::unique_copy;"
----------------
I would go with one per line. It will be much more diff-friendly this way.  And also much easier to add stuff in the middle and maybe keep it sorted. 


================
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:40-45
+    "std::all_of; std::any_of; std::none_of; std::find_if_not; "
+    "std::is_permutation; std::copy_n; std::copy_if; std::move; "
+    "std::move_backward; std::shuffle; std::is_partitioned;"
+    "std::partition_copy; std::partition_point; std::is_sorted"
+    "std::is_sorted_until; std::is_heap; std::is_heap_until; std::minmax; "
+    "std::minmax_element";
----------------
Same here.


https://reviews.llvm.org/D27806