[PATCH] D27806: [clang-tidy] Add obvious-invalid-range

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 15 10:35:23 PST 2016


Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/misc/InvalidRangeCheck.cpp:78
+void InvalidRangeCheck::check(const MatchFinder::MatchResult &Result) {
+
+  const auto *FirstArg = Result.Nodes.getNodeAs<DeclRefExpr>("first_arg");
----------------
Please remove empty line.


================
Comment at: docs/ReleaseNotes.rst:88
+  Warns if algorithm is used with ``.begin()`` and ``.end()`` from different
+  variables.
+
----------------
Probably container will be better word. Same for documentation.


================
Comment at: test/clang-tidy/misc-invalid-range.cpp:28
+};
+}
+
----------------
Please add closing namespace comment and empty line bfore.


https://reviews.llvm.org/D27806





More information about the cfe-commits mailing list