[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 15 09:22:59 PST 2016

a.sidorin added a comment.

Thank you Devin!

Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:30
+// The gtest unit testing API provides macros for assertions that that expand
+// into an if statement that calls a series of constructors and returns
"that that"

Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:105
+  void modelAssertionResultBoolConstructor(const CXXConstructorCall *Call,
+                                               CheckerContext &C) const;
Misalignment here and below

Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:182
+  SVal ThisSuccess = getAssertionResultSuccessFieldValue(AssertResultClassDecl,
+                                                         ThisVal, State);
Shouldn't we just bind OtherSuccess to our field?


More information about the cfe-commits mailing list