[libcxx] r286789 - Add check-cxx-abilist target when supported.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 14 23:49:03 PST 2016

> Eric, this part of this change seems wrong to me. It causes the headers to
> be installed into the libcxx build directory instead of the LLVM one. If
> you build using the LLVM runtimes directory this puts the headers in the
> wrong place for clang to find them.
> Is there a reason you're copying them into the libcxx binary dir? I
> generally don't think the headers are needed there.
If it seems wrong for building in the LLVM runtimes directory then it
probably is. I don't think there is a good reason why we need to copy the
headers into the build directory, although we should double check
compiler-rt uses the headers from the source directory.

If you know how to fix this feel free to commit a patch. If not I'll look
into this more on Friday.

@Dan, @Jonathan: Do you guys use, or see a need for, this behavior?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161215/9c1483b0/attachment.html>

More information about the cfe-commits mailing list