[PATCH] D27740: [analyzer] Include type name in Retain Count Checker diagnostics

Devin Coughlin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 14 14:10:23 PST 2016

dcoughlin added inline comments.

Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:2000
+        if (Sym->getType().isNull()) {
+          os << " returns an Objective-C object with a ";
+        } else {
I think we should use this diagnostic text when type is not an ObjCObjectPointerType also. Where this matters, I think, is for id.

It seems weird to say "returns an instance of id"; I think it would be better in that case to say "returns an Objective-C object".


More information about the cfe-commits mailing list