[PATCH] D27748: [clang-tidy] Suggest including <cmath> if necessary in type-promotion-in-math-fn-check.

Justin Lebar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 23:02:16 PST 2016

jlebar marked 2 inline comments as done.
jlebar added a comment.

Thank you for the review, @alexfh.  I will commit with these changes.

Comment at: clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:198
+            Result.Context->getSourceManager().getFileID(Call->getLocStart()),
+            "cmath", /* IsAngled = */ true))
+      D << *IncludeFixit;
alexfh wrote:
> Remove all spaces inside the argument comment, it's more common that way and clang-format understand it better.
Done, but FWIW it seems that clang-format will not insert a linebreak between the comment and the arg even with the spaces.  It is much more common in llvm, though, as you say.


More information about the cfe-commits mailing list