[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 21:35:01 PST 2016

beanz accepted this revision.
beanz added a comment.

LGTM other than a few style comments. Please clang-format before committing. Some of the formatting looks off (although that might just be my phone).

Comment at: lib/Support/PrettyStackTrace.cpp:152
+  va_start(ap, format);
+  const int size_or_error = vsnprintf(nullptr, 0, format, ap);
+  va_end(ap);
Your variable names are very LLDB-esque. Please follow the LLVM style guide, which is CamelCase.



More information about the cfe-commits mailing list