[PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.
Justin Lebar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 13 19:21:39 PST 2016
jlebar marked an inline comment as done.
jlebar added a comment.
In https://reviews.llvm.org/D27284#621052, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D27284#609937, @Eugene.Zelenko wrote:
> > Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
> This has not been done.
Indeed, sorry I missed that. Done now, will be reflected when I submit.
Comment at: clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:167-168
+ // FIXME: Perhaps we should suggest #include <cmath> if we suggest a cmath
+ // function and cmath is not already included.
> We definitely should. See the use of IncludeInserter in UnnecessaryValueParamCheck, for example. Fine for a follow-up.
OK, would rather send a followup because this patch is already nontrivial. I'll get to work on that -- thank you for the pointer.
More information about the cfe-commits