[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

David Gross via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 15:20:02 PST 2016

dgross added a comment.

In https://reviews.llvm.org/D27597#621596, @probinson wrote:

> As dblaikie said in email, probably better to make this X86-specific; if long-double varies by OS you can put in a specific triple.

I think with this approach I'd want two test cases that are identical except for consideration of long double size: One that specifies a target where long double is "small" and one where it is "large".  Actually, I guess I could make this a single test case, but have two compile and two filecheck lines, specifying different triples, as you suggest.  Or even three: One for whatever the default target is (doesn't check long double), one for a triple where long double is small, and one for a triple where long double is large.

> FTR we don't rely on Perl being available everywhere, anything that does this kind of scripty stuff uses Python.

So would a Python equivalent of the Perl be acceptable?  I think this is an academic question -- better to explicitly test multiple triples.


More information about the cfe-commits mailing list