[PATCH] D22296: CodeGen: New vtable group representation: struct of vtable arrays.

Peter Collingbourne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 11:23:47 PST 2016

pcc marked 3 inline comments as done.
pcc added inline comments.

Comment at: clang/include/clang/AST/VTableBuilder.h:255
+    operator ArrayRef<T>() const { return {data(), size()}; };
+  };
rjmccall wrote:
> Maybe this ought to be in LLVM as OwnedArrayRef?  And the more minimal implementation approach would be to inherit from MutableArrayRef<T> and just add a destructor and a move constructor.
> The implicit conversion to ArrayRef is dangerous, but only in ways that ArrayRef is already dangerous.
Good suggestions -- sent out D27723.


More information about the cfe-commits mailing list