[PATCH] D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check

Piotr Padlewski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 08:10:25 PST 2016


Prazek added inline comments.


================
Comment at: clang-tidy/utils/ExprSequence.cpp:52
+
+bool isDescendantOrEqual(const Stmt *Descendant, const Stmt *Ancestor,
+                         ASTContext *Context) {
----------------
staronj wrote:
> Shouldn't isDescendantOrEqual be static or in inline namespace?
Goot catch. I guess putting it with getParentStmts into anonymous namespace is the best solution.
btw inline namespace is not the same as anonymous namespace :)


https://reviews.llvm.org/D27700





More information about the cfe-commits mailing list