[PATCH] D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 13 07:27:22 PST 2016
alexfh added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:154
+ return SyntheticStmtSourceMap.lookup(S);
+ return S;
> alexfh wrote:
> > nit: No `else` after return, please.
> Not sure if he should change it in this patch - it is just move of this class to different file, so I am not sure if it is good do introduce small changes to it now.
> I guess pushin NFC patch with this after would be good solution
For me it's usually easier to fix than to postpone to a different patch. Feel free to do either.
More information about the cfe-commits