[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

Ben Harper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 05:18:43 PST 2016

bmharper updated this revision to Diff 81213.
bmharper added a comment.

Sorry for the incredibly long turnaround time on this one - I don't have any legitimate excuse, and I know it just makes reviewing it harder.

Anyway - I have sorted out all the issues mentioned in the last review. One thing that you suggested was to go ahead and replace the std::pair for NestingAndIndentLevel, which I did write, but I feel like it adds quite a bit of bloat, because you need two constructors, operator==, operator!=, operator<, operator>, so I'm not convinced that it's worth it in the end. If you still think it is, then I'll go ahead and add it.




-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21279.81213.patch
Type: text/x-patch
Size: 24575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161213/a1e08ef5/attachment-0001.bin>

More information about the cfe-commits mailing list