[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

[David Gross via cfe-commits]

I looked at what's supported by "requires", and couldn't find anything
appropriate.

The problem is that I want the test to be sensitive to the size of long
double -- either no greater than 64 bits, or greater than 64 bits.  It does
not seem practical to list all platforms (so I suspect your "xfail"
suggestion would not be suitable).  I'd like to find some way to make the
determination programmatically in the test suite.  It's certainly possible
that the answer is that there's no good way to do it.


On Mon, Dec 12, 2016 at 11:31 AM, David Blaikie <dblaikie at gmail.com> wrote:

> While it's possible to do arbitrary script things - we prefer nto to to
> ensure the tests are portable. (we have some custom implementations of
> common unix utilities for portability of those).
>
> In this case, can you xfail this on platforms that don't have the feature
> you want? rather than trying to detect it at test-execution time. (or say
> "requires" to opt the test in only on platforms you know have the thing you
> want)
>
> On Fri, Dec 9, 2016 at 4:00 AM David Gross via Phabricator via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>
>> dgross added a comment.
>>
>> I don't know exactly what the RUN syntax supported by lit is.  What I've
>> done here looks complex, but it does work for Linux.  What about other
>> platforms?
>>
>> Is there some better way of writing a test case where the checks to be
>> done by FileCheck depend on some property of the file being analyzed (here,
>> the size of long double, as embedded in the debug metadata)?  I don't see
>> any support for conditions in FileCheck.
>>
>> Maybe I'm going about this completely the wrong way?
>>
>>
>> https://reviews.llvm.org/D27597
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161212/14de62ac/attachment.html>