[PATCH] D27631: [CUDA,Driver] Added --no-cuda-gpu-arch= option.

Justin Lebar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 9 13:41:46 PST 2016


jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Driver/Driver.cpp:1952
+
+
+      // Default to sm_20 which is the lowest common denominator for
----------------
Extra linebreak


================
Comment at: lib/Driver/Driver.cpp:1960
+        // Sort GpuArchList to make compilation order deterministic.
+        std::sort(GpuArchList.begin(), GpuArchList.end());
 
----------------
We're using std::set, so I don't think this is necessary?  You could have a comment on std::set saying that we use it to get a deterministic order, if you want.


================
Comment at: test/Driver/cuda-options.cu:154
+
+
 // Match device-side preprocessor and compiler phases with -save-temps.
----------------
Extra linebreak


https://reviews.llvm.org/D27631





More information about the cfe-commits mailing list