[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 9 10:04:45 PST 2016


erichkeane updated this revision to Diff 80913.
erichkeane marked an inline comment as done.
erichkeane added a comment.

Based on the tests, I was able to track down the 2 locations that stopped working.  I've updated them appropriately.

It seems though that this Template Decl Instantiation is the ONLY time that the attributes aren't just initialized immediately.  This gets me wondering if I should just create a pair of functions for it specifically?  It would likely be a little bit of re-work on InstatiateAttrs (perhaps separate the implementation to take the instantiateTemplateAttrribute 'function' as a parameter), but would that be preferential?


https://reviews.llvm.org/D27529

Files:
  include/clang/Basic/Attr.td
  include/clang/Sema/Sema.h
  lib/Sema/SemaTemplate.cpp
  lib/Sema/SemaTemplateInstantiate.cpp
  lib/Sema/SemaTemplateInstantiateDecl.cpp
  test/CXX/dcl.dcl/dcl.attr/dcl.attr.deprecated/p1.cpp
  utils/TableGen/ClangAttrEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27529.80913.patch
Type: text/x-patch
Size: 8226 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161209/1a5577dd/attachment.bin>


More information about the cfe-commits mailing list