[PATCH] D27545: Don't assert when redefining a built-in macro in a PCH, PR29119

[Nico Weber via cfe-commits]

(I replied to comments about 1h ago, looks like phab is not in the mood for
sending a mail for that for some reason. I did use the "Leap into action"
submit button.)

On Wed, Dec 7, 2016 at 9:19 PM, Richard Smith via Phabricator <
reviews at reviews.llvm.org> wrote:

> rsmith added inline comments.
>
>
> ================
> Comment at: lib/Lex/PPMacroExpansion.cpp:110-112
> +    // FIXME: shouldIgnoreMacro() in ASTWriter also stops at macros from
> the
> +    // predefines buffer in module builds. Do we need to splice to those
> here
> +    // too?
> ----------------
> If I remember correctly, we shouldn't need to; we run this step before we
> start lexing the predefines buffer. However, that does mean that macros on
> the command line will *override* macros from the PCH, which seems like it's
> probably the wrong behavior...
>
>
> https://reviews.llvm.org/D27545
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161208/ba02103f/attachment.html>