[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

[David Majnemer via Phabricator via cfe-commits]

majnemer added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:3871
+    for (auto &I : FI.arguments()) {
+      if (Count < 6)
+        I.info = classify(I.type, FreeSSERegs, false, IsVectorCall, IsRegCall);
----------------
erichkeane wrote:
> majnemer wrote:
> > majnemer wrote:
> > > And here,
> > I was OK with `6` showing up in prior code because there was a comment but there isn't such a comment down here.  Maybe we should have this `6` live in an enum?
> Thats a good point.  Any reason it couldn't just be a static constant in each of the ABIInfos?  Or am I missing your point?
It could be but LLVM usually prefers enums over class-scope static variables.  They require an awkward definition somewhere should they be ODR used.


https://reviews.llvm.org/D27529