[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

[Malcolm Parsons via Phabricator via cfe-commits]

malcolm.parsons added inline comments.


================
Comment at: clang-tidy/google/GoogleTidyModule.cpp:68
+    CheckFactories.registerCheck<readability::GlobalNamesCheck>(
+        "google-global-names");
     CheckFactories.registerCheck<clang::tidy::readability::FunctionSizeCheck>(
----------------
bkramer wrote:
> aaron.ballman wrote:
> > Given that this was shipped under the old name, I think we need to figure out our policy for how to handle this. It also comes up in D26511, so I would like us to be consistent with what we do.
> There was no special handling in D26511, so I left this as-is.
D26511 made the existing check documentation redirect to the new documentation.


https://reviews.llvm.org/D23130