[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

[Douglas Yung via Phabricator via cfe-commits]

dyung created this revision.
dyung added a reviewer: kkwli0.
dyung added a subscriber: cfe-commits.

This test as originally written fails when run with a compiler that defaults to a different C++ standard. This patch fixes up the test and adds testing it explicitly using c++98 and c++11. The changes were adapted from similar work done in distribute_parallel_for_simd_collapse_messages.cpp.


https://reviews.llvm.org/D27488

Files:
  teams_distribute_simd_collapse_messages.cpp


Index: teams_distribute_simd_collapse_messages.cpp
===================================================================
--- teams_distribute_simd_collapse_messages.cpp
+++ teams_distribute_simd_collapse_messages.cpp
@@ -1,8 +1,13 @@
 // RUN: %clang_cc1 -verify -fopenmp %s
+// RUN: %clang_cc1 -verify -fopenmp -std=c++98 %s
+// RUN: %clang_cc1 -verify -fopenmp -std=c++11 %s
 
 void foo() {
 }
 
+#if __cplusplus >= 201103L
+// expected-note at +2 4 {{declared here}}
+#endif
 bool foobool(int argc) {
   return argc;
 }
@@ -50,9 +55,12 @@
   for (int i = ST; i < N; i++)
     argv[0][i] = argv[0][i] - argv[0][i-ST]; // expected-error 2 {{expected 2 for loops after '#pragma omp teams distribute simd', but found only 1}}
 
-// expected-error at +4 2 {{directive '#pragma omp teams distribute simd' cannot contain more than one 'collapse' clause}}
-// expected-error at +3 2 {{argument to 'collapse' clause must be a strictly positive integer value}}
-// expected-error at +2 2 {{expression is not an integral constant expression}}
+// expected-error at +7 2 {{directive '#pragma omp teams distribute simd' cannot contain more than one 'collapse' clause}}
+// expected-error at +6 2 {{argument to 'collapse' clause must be a strictly positive integer value}}
+// expected-error at +5 2 {{expression is not an integral constant expression}}
+#if __cplusplus >= 201103L
+// expected-note at +3 2 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
+#endif
 #pragma omp target
 #pragma omp teams distribute simd collapse (foobool(argc)), collapse (true), collapse (-5)
   for (int i = ST; i < N; i++)
@@ -62,7 +70,11 @@
   for (int i = ST; i < N; i++)
     argv[0][i] = argv[0][i] - argv[0][i-ST];
 
-// expected-error at +2 2 {{expression is not an integral constant expression}}
+#if __cplusplus <= 199711L
+  // expected-error at +5 2 {{expression is not an integral constant expression}}
+#else
+  // expected-error at +3 2 {{integral constant expression must have integral or unscoped enumeration type, not 'char *'}}
+#endif
 #pragma omp target
 #pragma omp teams distribute simd collapse (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
   for (int i = ST; i < N; i++)
@@ -110,14 +122,20 @@
   for (int i = 4; i < 12; i++)
     argv[0][i] = argv[0][i] - argv[0][i-4]; // expected-error {{expected 4 for loops after '#pragma omp teams distribute simd', but found only 1}}
 
+#if __cplusplus >= 201103L
+  // expected-note at +3 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
+#endif
 #pragma omp target
 #pragma omp teams distribute simd collapse (foobool(1) > 0 ? 1 : 2) // expected-error {{expression is not an integral constant expression}}
   for (int i = 4; i < 12; i++)
     argv[0][i] = argv[0][i] - argv[0][i-4];
 
-// expected-error at +4 {{expression is not an integral constant expression}}
-// expected-error at +3 2 {{directive '#pragma omp teams distribute simd' cannot contain more than one 'collapse' clause}}
-// expected-error at +2 2 {{argument to 'collapse' clause must be a strictly positive integer value}}
+// expected-error at +7 {{expression is not an integral constant expression}}
+// expected-error at +6 2 {{directive '#pragma omp teams distribute simd' cannot contain more than one 'collapse' clause}}
+// expected-error at +5 2 {{argument to 'collapse' clause must be a strictly positive integer value}}
+#if __cplusplus >= 201103L
+// expected-note at +3 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
+#endif
 #pragma omp target
 #pragma omp teams distribute simd collapse (foobool(argc)), collapse (true), collapse (-5) 
   for (int i = 4; i < 12; i++)
@@ -128,7 +146,11 @@
   for (int i = 4; i < 12; i++)
     argv[0][i] = argv[0][i] - argv[0][i-4];
 
-// expected-error at +2 {{expression is not an integral constant expression}}
+#if __cplusplus >= 201103L
+  // expected-error at +5 {{integral constant expression must have integral or unscoped enumeration type, not 'char *'}}
+#else
+  // expected-error at +3 {{expression is not an integral constant expression}}
+#endif
 #pragma omp target
 #pragma omp teams distribute simd collapse (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
   for (int i = 4; i < 12; i++)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27488.80496.patch
Type: text/x-patch
Size: 4247 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161206/169687f4/attachment-0001.bin>