[PATCH] D27409: [analyzer] RetainCountChecker: Improve support for libdispatch APIs.

Devin Coughlin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 6 09:30:16 PST 2016


dcoughlin added a comment.

In https://reviews.llvm.org/D27409#614601, @NoQ wrote:

> Not sure we need to stay merged with `retain-release-arc.m`, as we're not really reusing many declarations across these files.


I find it more helpful to organize tests around functionality ('retain count checker') than around bugs ('dispatch data leak', 'PRxyzab.c').  Organizing around functionality helps future contributors and maintainers know where to add a new test and where to look for existing tests. In my view this critical for developers who are new to the project or who are learning a new subsystem. It also typically reduces the number of 'clang' RUN lines, which have a cost in maintenance and running time.


https://reviews.llvm.org/D27409





More information about the cfe-commits mailing list