[PATCH] D27408: [analyzer] RetainCountChecker: remove unused enum value; NFC.

Anna Zaks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 5 09:03:18 PST 2016


zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.

I suspect allocated owned means that the analyzer saw the allocation site.

Removing dead code is great! Thanks. This looks good to me other than the name of the method that I commented about.



================
Comment at: include/clang/StaticAnalyzer/Checkers/ObjCRetainCount.h:179
   
-  static RetEffect MakeOwned(ObjKind o, bool isAllocated = false) {
-    return RetEffect(isAllocated ? OwnedAllocatedSymbol : OwnedSymbol, o);
+  static RetEffect MakeOwned(ObjKind o) {
+    return RetEffect(OwnedAllocatedSymbol, o);
----------------
Should we rename into MakeAllocatedOwned()?


https://reviews.llvm.org/D27408





More information about the cfe-commits mailing list