[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

Malcolm Parsons via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 30 09:48:03 PST 2016


On 30 November 2016 at 17:18, Mads Ravn <madsravn at gmail.com> wrote:
> So remove the ifStmt from the third and fourth case?

I was thinking all cases.
Can the first case be restricted to casts to bool?
If not, keep the cast to int case with an ifStmt and add a cast to bool case.
Does it matter whether the cast is implicit?

-- 
Malcolm Parsons


More information about the cfe-commits mailing list