[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 29 11:05:47 PST 2016


Eugene.Zelenko added a comment.

Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).



================
Comment at: docs/clang-tidy/checks/misc-string-compare.rst:8
+
+A common mistake is to use the string's compare method instead of using the 
+equality or inequality operators. The compare method is intended for sorting
----------------
Please enclose compare in ``. Probably will be good idea to add (). Same below.


================
Comment at: docs/clang-tidy/checks/misc-string-compare.rst:10
+equality or inequality operators. The compare method is intended for sorting
+functions and thus returns -1, 0 or 1 depending on the lexicographical 
+relationship between the strings compared. If an equality or inequality check
----------------
Please enclose -1, 0 and 1 in `.


Repository:
  rL LLVM

https://reviews.llvm.org/D27210





More information about the cfe-commits mailing list