[PATCH] D27095: Protect std::array tests under noexceptions

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 28 11:01:03 PST 2016


mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

Other than the missing `assert`s, (which are not your fault, but I would appreciate you fixing) this LGTM.



================
Comment at: test/std/containers/sequences/array/at.pass.cpp:43
+#ifndef TEST_HAS_NO_EXCEPTIONS
         try { (void) c.at(3); }
         catch (const std::out_of_range &) {}
----------------
we should really have an `assert(false);` after the call to `at` - to make sure that it actually throws.

Here and below.



https://reviews.llvm.org/D27095





More information about the cfe-commits mailing list