[PATCH] D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl
Kareem Khazem via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Nov 27 21:44:42 PST 2016
khazem updated this revision to Diff 79371.
khazem added a comment.
Thanks for the comments, Aleksei!
I've merged some aspects of the code you pointed me to, although I had to change some of it because some of the function calls have changed since 2015. In particular, I'm checking for already-imported functions, and adding the decl to the imported map.
I'm not sure how to proceed with tests. I was looking at test/ASTMerge/class-template-partial-spec.cpp, would it be something like this?
But I'm not sure what error I should throw if we have already imported the function, there is no appropriate error in include/clang/Basic/DiagnosticASTKinds.td. Should I define a new error, e.g. "function %0 defined in multiple translation units"?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 10069 bytes
Desc: not available
More information about the cfe-commits