[PATCH] D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 25 09:01:10 PST 2016


ABataev added inline comments.


================
Comment at: lib/Basic/OpenMPKinds.cpp:685
 
 bool clang::isOpenMPWorksharingDirective(OpenMPDirectiveKind DKind) {
   return DKind == OMPD_for || DKind == OMPD_for_simd ||
----------------
I think this new directive must be considered as a worksharing directive also.


================
Comment at: lib/Parse/ParseOpenMP.cpp:21
 #include "llvm/ADT/PointerIntPair.h"
-
 using namespace clang;
----------------
Restore this line


================
Comment at: test/OpenMP/nesting_of_regions.cpp:3326
   }
-#pragma omp ordered
   {
----------------
what about teams distribute parallel for simd inside the ordered directive? Why this one is removed?


https://reviews.llvm.org/D27084





More information about the cfe-commits mailing list